RSGallery2 Support Forums

RSgallery2 support forums => Display and Templates => Topic started by: Amgeek on October 09, 2007, 01:00:55 pm



Title: All text distorted
Post by: Amgeek on October 09, 2007, 01:00:55 pm
Hi

All text distorted. Squished horizontally.
Think I have attached screen shots.

Thanks



Title: Re: All text distorted
Post by: Jonah on October 09, 2007, 01:40:59 pm
It almost looks like the text is cut off on the top or bottom.  Must be a style sheet in your template.  If you post a link to your site the problem might be easy to find.


Title: Re: All text distorted
Post by: Amgeek on October 09, 2007, 01:45:27 pm
Exactly.

www.color.amgeek.com

Then "RSgallery Test" on top menu.

Using default RSgallery theme.
Site theme is RocketTheme Colormatic.

Thanks


Title: Re: All text distorted
Post by: Jonah on October 09, 2007, 01:53:41 pm
I clicked it but it didn't show any galleries listed.  If it's an issue with a Rockettheme template we definitely want to get that fixed.

In terms of administration only, what do you like better, Expose or RSG2?


Title: Re: All text distorted
Post by: Amgeek on October 09, 2007, 02:44:30 pm
Thanks for the prompt reply.

There is now a couple of pictures in it.  :)

Have not used either enough to know but from what little I have seen of each I am leaning towards RS.


Looking forward to finding out and will let you know when I do.


Thanks


Title: Re: All text distorted
Post by: Jonah on October 09, 2007, 08:33:49 pm
There is a broken div on the page.  The net effect is it is collapsing the text into a clr line of 0 height.  Try HTML validating it to see what I'm saying.

Do you mind trying another off the self rockettheme or default template?  I would like to see if it's RSG2 that is broken or the template.  What version of RSG2 are you using?

The reason I ask about expose is that we have been thinking about implementing it's flash viewer as a template for RSG2.  So you would do the administration with RSG2 but view the images with the Expose image viewer.  I am interested in your feedback on that.



Title: Re: All text distorted
Post by: Amgeek on October 11, 2007, 05:28:48 am
I think I checked the HTML (really green at all this  ::) ) the damage was caused by my attempt to move and modify the java entries and remark out the scripts to prevent conflicts with other plugins.

I have installed a fresh copy of Joomla and Colormatic at color2.Amgeek.com. No modifications to either except the install of RSGallery2. The distorted text is still there.


Title: Re: All text distorted
Post by: Jonah on October 19, 2007, 03:37:30 pm
I installed the colormatic template and instantly reproduced the issue.  Both their css and ours define a clr class selector.  But they are used in different ways.  The name of theirs or ours must be changed in order to fix the issue.


Title: Re: All text distorted
Post by: Amgeek on October 20, 2007, 09:57:28 am
Thanks.

How would I do that in RS?


Title: Re: All text distorted
Post by: Jonah on October 20, 2007, 10:30:46 am
Edit components/com_rsgallery2/templates/semantic/css/template.css.  Change .clr to .rclr or something like that.

Then changed every instance of class='clr' in all the other files in components/com_rsgallery2/templates/semantic/ to rclr.

You might want to change your template instead.  It will probably be easier and save you the trouble of editing RSG2 again after you upgrade.


Title: Re: All text distorted
Post by: Amgeek on October 21, 2007, 04:01:17 pm
Hi James and Jonah:

Posting this reply to both forums. Hope you don’t mind. Think that if we all work together on this one we can eventually figure it out.

To recap, I am trying to install RSGallery2 in Colormatic (Rocket Theme Template) and get distorted text in RSGallery2 when I do.

http://rsgallery2.net/component/option,com_smf/Itemid,17/topic,7216.new/topicseen,topicseen

http://www.rockettheme.com/option,com_smf/Itemid,190/topic,20202.new/topicseen,1/#new


I have set up two test websites:


RSgallery2 on clean Colomatic
http://rsg2rc.amgeek.com/index.php?option=com_rsgallery2&Itemid=49

RSGallery2 on clean Joomla
http://rsg2j.amgeek.com/index.php?option=com_rsgallery2&Itemid=0

RSGallery works fairly well on the clean Joomla install. However, it distorts, not only itself, but other modules on the page, when installed on Colormatic.

(see attached or visit site)

Jonah has suggested in the past that there may be a broken /DIV somewhere in the Colormatic template. I don’t think I would recognize it if I could find it.

There is a broken div on the page.  The net effect is it is collapsing the text into a clr line of 0 height.  Try HTML validating it to see what I'm saying.

He also says that both Colormatic and RSGallery2 both use a .clr class and that is confusing thing because they both use it differently and suggested I rename one or both to end the confusion.


                                       ----------------------------------------------------------------------------------------

   
I searched the com_rsgallery folder and can only find one references to “clr” in  rsgallery.css and one in the several template.css files (total of 4, none in any of their sub-folders).

Renamed lines 252 - 257 in template.css and tested – no change.
Commented out lines 252 - 257 in template.css – no change.
            ------------------------------

I also have searched Colormatic for “clr”  and found three files: Install.css, template.css.css and admin_login.css.  I am going to assume (correct me if I am wrong) that the install.css and admin_login.css are not players in this issue.

Searched template.css.css for “clr”. Only found one instance, lines 675 – 677.


.clr {
   clear: both;
}

Commented it out – no change.


         ---------------------------------

James suggested I add



   Try adding this to template_css.css

Quote
ul#rsg2-navigation li {
line-height: 10px;
}
added to lines 831 – 833


This one brought “Main Gallery Page” into view



And then

Try
ul#rsg2-galleryList li,
ul#rsg2-navigation li {
line-height: 10px;
}

Modified lines 831- 835


No change.


Title: Re: All text distorted
Post by: Amgeek on October 22, 2007, 06:23:32 am
Reply from Rocket Themes

Re: RSGallery2 and Colormatic
« Reply #7 on: October 22, 2007, 02:56:18 AM »   

                                                               
In Colormatic's template_css.css, you have


Quote
.clr {
line-height: 0px;
}

I suspect that is a mod since my last visit but try increasing that.

                                                                                   ******************************




Thanks for sticking with it James.

That statement should be commented out in template.css.css :


Lines 674 - 677 in Colormatic template.css.css

/*.clr {
   clear: both;
} */

As well as in RSGallery:

Lines 253 - 257 in RSGallery/Template/semantic/css/template.css

/* utility selector, this is common in many templates, but we can't count on it being there */
/* .clr{
    clear: both;
    line-height: 0px;
} */


Try uncommenting and modifying in template.css.css

.clr {
clear: both;
line-height: 20px;
}


No change

Also try (in addition to above)

Lines 253 - 257 in RSGallery/Template/semantic/css/template.css

/* utility selector, this is common in many templates, but we can't count on it being there */
.clr{
    clear: both;
    line-height: 20px;
}
No change.


Title: Re: All text distorted
Post by: Jonah on October 22, 2007, 09:12:57 am
There are numerous ways you can could fix this issue Amgeek.  Using Firebug I believe the quickest fix is to comment out line 153 of /components/com_rsgallery2/templates/tables/css/template.css

We will rename our clear class to something else so that this problem does not occur in future releases.


Title: Re: All text distorted
Post by: Amgeek on October 23, 2007, 05:27:34 am

By golly fellas, WE DID IT!

Per Jonah?s last suggestion, I tried looking at RSGallery/Template/semantic/css/template.css and did not find the suggested entry at line 153. I did find it in RSGallery/Template/Tables/css/template.css

Changed that and guess what?

We were chasing the WRONG DOG!!!!!!!!

It was not the semantic css file but the tables.css file!
 Changed lines 153 - 156 from:
.clr{
    clear: both;
    line-height: 0px;
}
To:
.rsg2clr{
    clear: both;
    line-height: 0px;
}
No other changes to either RSGallery2 or Colormatic were needed.

Probably a good idea to do it for all template.css files in the
 / RSGallery/Template/ folder that have similar entries.



In any event, Jonah, changing your naming conventions is still a good idea and will help insure that two great products will work great together.


THANK YOU BOTH

As soon as either of you are old enough, have a beer on me!


Title: Re: All text distorted
Post by: Jonah on October 23, 2007, 11:21:58 am
 :)  glad to hear it worked out.

Be sure to check out RSG2 1.14 when it comes out.  There will be a bunch of cool templates released with it.


Title: Re: All text distorted
Post by: Denise Beach on October 30, 2007, 07:20:11 pm
I registered here for the sole purpose of posting a big fat THANK YOU!  I'm building a website for my church, and this problem was driving me crazy!  The simple little change did wonders, and I just wanted to say thank you for sharing the solution.  I was about to lose my mind!


Title: Re: All text distorted
Post by: fatihalp on November 15, 2007, 03:11:46 am
Thanks a lot  :D